Hi Marko, On Tue, Jul 05, 2022 at 11:53:58AM +0300, Marko Mäkelä wrote: > The flag LIRC_SCANCODE_FLAG_REPEAT was never set by rc_keydown(). > Previously it was only set by rc_repeat(), but not all protocol > decoders invoke that function. This should say _why_ you are making this change, not _what_ the change is. See: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes This also applies the first line of the commit. Thanks Sean > > Signed-off-by: Marko Mäkelä <marko.makela@xxxxxx> > --- > drivers/media/rc/rc-main.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c > index b90438a71c80..d914197245eb 100644 > --- a/drivers/media/rc/rc-main.c > +++ b/drivers/media/rc/rc-main.c > @@ -786,7 +786,8 @@ static void ir_do_keydown(struct rc_dev *dev, enum rc_proto protocol, > dev->last_toggle != toggle); > struct lirc_scancode sc = { > .scancode = scancode, .rc_proto = protocol, > - .flags = toggle ? LIRC_SCANCODE_FLAG_TOGGLE : 0, > + .flags = (toggle ? LIRC_SCANCODE_FLAG_TOGGLE : 0) | > + (!new_event ? LIRC_SCANCODE_FLAG_REPEAT : 0), > .keycode = keycode > }; > > -- > 2.36.1
