Hi Paul, Thank you for the patch. On Wed, Jun 15, 2022 at 04:11:19AM +0900, Paul Elder wrote: > The i.MX8MP ISP is compatbile with the rkisp1 driver. Add it to the list > of compatible strings. While at it, expand on the description of the > clocks to make it clear which clock in the i.MX8MP ISP they map to, > based on the names from the datasheet (which are confusing). > > Signed-off-by: Paul Elder <paul.elder@xxxxxxxxxxxxxxxx> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > Documentation/devicetree/bindings/media/rockchip-isp1.yaml | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/rockchip-isp1.yaml b/Documentation/devicetree/bindings/media/rockchip-isp1.yaml > index b3661d7d4357..95cf945f7ac5 100644 > --- a/Documentation/devicetree/bindings/media/rockchip-isp1.yaml > +++ b/Documentation/devicetree/bindings/media/rockchip-isp1.yaml > @@ -16,6 +16,7 @@ description: | > properties: > compatible: > enum: > + - fsl,imx8mp-isp > - rockchip,px30-cif-isp > - rockchip,rk3399-cif-isp > > @@ -36,9 +37,9 @@ properties: > minItems: 3 > items: > # isp0 and isp1 > - - description: ISP clock > - - description: ISP AXI clock > - - description: ISP AHB clock > + - description: ISP clock (for imx8mp, clk) > + - description: ISP AXI clock (for imx8mp, m_hclk) > + - description: ISP AHB clock (for imx8mp, hclk) > # only for isp1 > - description: ISP Pixel clock > -- Regards, Laurent Pinchart
