Hi Paul, Thank you for the patch. On Wed, Jun 15, 2022 at 04:11:15AM +0900, Paul Elder wrote: > The rkisp1 can take an input on the parallel interface. Add a port for > it, and update the required field. At least one port is required, and > both may be specified. > > Signed-off-by: Paul Elder <paul.elder@xxxxxxxxxxxxxxxx> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > .../bindings/media/rockchip-isp1.yaml | 23 +++++++++++++++++-- > 1 file changed, 21 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/rockchip-isp1.yaml b/Documentation/devicetree/bindings/media/rockchip-isp1.yaml > index d1489b177331..b3661d7d4357 100644 > --- a/Documentation/devicetree/bindings/media/rockchip-isp1.yaml > +++ b/Documentation/devicetree/bindings/media/rockchip-isp1.yaml > @@ -84,8 +84,27 @@ properties: > minItems: 1 > maxItems: 4 > > - required: > - - port@0 > + port@1: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: connection point for input on the parallel interface > + > + properties: > + bus-type: > + enum: [5, 6] > + > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + required: > + - bus-type > + > + anyOf: > + - required: > + - port@0 > + - required: > + - port@1 > > required: > - compatible -- Regards, Laurent Pinchart