Hi Laurent, I love your patch! Perhaps something to improve: [auto build test WARNING on media-tree/master] [also build test WARNING on linus/master v5.19-rc2 next-20220617] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Laurent-Pinchart/media-Replace-dependency-on-VIDEO_V4L2_SUBDEV_API-with-select/20220617-003721 base: git://linuxtv.org/media_tree.git master config: (https://download.01.org/0day-ci/archive/20220618/202206180224.IQyAlsqP-lkp@xxxxxxxxx/config) reproduce: # https://github.com/intel-lab-lkp/linux/commit/efc926771b1dc55aaa144308fd649aa1bc6e69ba git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Laurent-Pinchart/media-Replace-dependency-on-VIDEO_V4L2_SUBDEV_API-with-select/20220617-003721 git checkout efc926771b1dc55aaa144308fd649aa1bc6e69ba # 1. reproduce by kismet # install kmax per https://github.com/paulgazz/kmax/blob/master/README.md kismet --linux-ksrc=linux --selectees CONFIG_VIDEO_V4L2_SUBDEV_API --selectors CONFIG_V4L2_FLASH_LED_CLASS -a=x86_64 # 2. reproduce by make # save the config file to linux source tree cd linux make ARCH=x86_64 olddefconfig If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> kismet warnings: (new ones prefixed by >>) >> kismet: WARNING: unmet direct dependencies detected for VIDEO_V4L2_SUBDEV_API when selected by V4L2_FLASH_LED_CLASS WARNING: unmet direct dependencies detected for VIDEO_V4L2_SUBDEV_API Depends on [n]: MEDIA_SUPPORT [=y] && VIDEO_DEV [=y] && MEDIA_CONTROLLER [=n] Selected by [y]: - V4L2_FLASH_LED_CLASS [=y] && MEDIA_SUPPORT [=y] && VIDEO_DEV [=y] && LEDS_CLASS_FLASH [=y] -- 0-DAY CI Kernel Test Service https://01.org/lkp
