On Thu, Jun 16, 2022 at 07:36:32PM +0300, Laurent Pinchart wrote: > From: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > > The VIDEO_V4L2_SUBDEV_API Kconfig symbol is mostly selected > automatically, with a a handful of drivers still using it as a > dependency. Fix them to use selection, and drop the symbol title text to > not expose it for manual selection. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> Makes sense. Reviewed-by: Ezequiel Garcia <ezequiel@xxxxxxxxxxxxxxxxxxxx> > --- > drivers/media/i2c/Kconfig | 3 ++- > drivers/media/platform/atmel/Kconfig | 3 ++- > drivers/media/v4l2-core/Kconfig | 5 +++-- > 3 files changed, 7 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > index 2b20aa6c37b1..51fc3fb72d95 100644 > --- a/drivers/media/i2c/Kconfig > +++ b/drivers/media/i2c/Kconfig > @@ -75,8 +75,9 @@ config VIDEO_HI847 > > config VIDEO_IMX208 > tristate "Sony IMX208 sensor support" > - depends on I2C && VIDEO_DEV && VIDEO_V4L2_SUBDEV_API > + depends on I2C && VIDEO_DEV > depends on MEDIA_CAMERA_SUPPORT > + select VIDEO_V4L2_SUBDEV_API > help > This is a Video4Linux2 sensor driver for the Sony > IMX208 camera. > diff --git a/drivers/media/platform/atmel/Kconfig b/drivers/media/platform/atmel/Kconfig > index 83aebee0c8eb..da8ffc39d11d 100644 > --- a/drivers/media/platform/atmel/Kconfig > +++ b/drivers/media/platform/atmel/Kconfig > @@ -20,12 +20,13 @@ config VIDEO_ATMEL_ISC > config VIDEO_ATMEL_XISC > tristate "ATMEL eXtended Image Sensor Controller (XISC) support" > depends on V4L_PLATFORM_DRIVERS > - depends on VIDEO_DEV && COMMON_CLK && VIDEO_V4L2_SUBDEV_API > + depends on VIDEO_DEV && COMMON_CLK > depends on ARCH_AT91 || COMPILE_TEST > select VIDEOBUF2_DMA_CONTIG > select REGMAP_MMIO > select V4L2_FWNODE > select VIDEO_ATMEL_ISC_BASE > + select VIDEO_V4L2_SUBDEV_API > help > This module makes the ATMEL eXtended Image Sensor Controller > available as a v4l2 device. > diff --git a/drivers/media/v4l2-core/Kconfig b/drivers/media/v4l2-core/Kconfig > index 1be9a2cc947a..5141c8215b2f 100644 > --- a/drivers/media/v4l2-core/Kconfig > +++ b/drivers/media/v4l2-core/Kconfig > @@ -9,7 +9,7 @@ config VIDEO_V4L2_I2C > default y > > config VIDEO_V4L2_SUBDEV_API > - bool "V4L2 sub-device userspace API" > + bool > depends on VIDEO_DEV && MEDIA_CONTROLLER > help > Enables the V4L2 sub-device pad-level userspace API used to configure > @@ -56,9 +56,10 @@ config V4L2_MEM2MEM_DEV > # Used by LED subsystem flash drivers > config V4L2_FLASH_LED_CLASS > tristate "V4L2 flash API for LED flash class devices" > - depends on VIDEO_DEV && VIDEO_V4L2_SUBDEV_API > + depends on VIDEO_DEV > depends on LEDS_CLASS_FLASH > select V4L2_ASYNC > + select VIDEO_V4L2_SUBDEV_API > help > Say Y here to enable V4L2 flash API support for LED flash > class drivers. > -- > Regards, > > Laurent Pinchart >
