On Wed, 18 May 2022 at 13:57, Benjamin Marty <info@xxxxxxxxxxxxxxxx> wrote: > > Am Mi., 18. Mai 2022 um 01:09 Uhr schrieb Kieran Bingham > <kieran.bingham@xxxxxxxxxxxxxxxx>: > > Benjamin, how does it look on your system? I presume setting this bit > > improves image quality for your use case. > > Yes, it fixes the analog noise/grain issue. I have noticed too that > the image is getting softer, as described by Dave. > > Comparison Images from my side (Not the exact same frame): > https://drive.google.com/file/d/1gdwKUGb7GcvMVJG0uSomhMPeSfDwXId- > https://drive.google.com/file/d/1oitfhl4txzxOabI-TplpsKMqP2mr0TKy More exciting images from me, and they are from the same frame (DVD paused) https://photos.app.goo.gl/ztbW6uf6C8AguVnz7 for some stills from Tom & Jerry, and the Fantastic 4. The first image in each case is the register at 0x84 (new setting), and the second as 0x80 (old setting). The final images from Fantastic 4 are the most telling. The old setting produces a lot of crawling noise on the land areas of the earth, whilst with the new setting that is almost totally gone, so on that basis I'd vote for the new. I should add that I am using the I2P block in the chip to deinterlace the source. From what I understand of the I2P it's a pretty simple line doubling so that won't overly help image quality, but shouldn't make a difference in this case. Dave > > From a driver perspective, with no other existing expecatation - I would > > say matching the datasheet is the correct thing to do anyway. > > I'm also agreeing on the driver should be complying with the > Datasheet. I think it's a "Bug" and not a "Feature" that the Image > gets sharpened but more grainy when not setting this bit. > > Furthermore, I have opened a Ticket at ADV to get more details, but > I'm not really expecting a proper Answer. > > Benjamin
