Re: [PATCH v2] media: i2c: adv7180: fix reserved bit in Video Selection 2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Mi., 18. Mai 2022 um 01:09 Uhr schrieb Kieran Bingham
<kieran.bingham@xxxxxxxxxxxxxxxx>:
> Benjamin, how does it look on your system? I presume setting this bit
> improves image quality for your use case.

Yes, it fixes the analog noise/grain issue. I have noticed too that
the image is getting softer, as described by Dave.

Comparison Images from my side (Not the exact same frame):
https://drive.google.com/file/d/1gdwKUGb7GcvMVJG0uSomhMPeSfDwXId-
https://drive.google.com/file/d/1oitfhl4txzxOabI-TplpsKMqP2mr0TKy

> From a driver perspective, with no other existing expecatation - I would
> say matching the datasheet is the correct thing to do anyway.

I'm also agreeing on the driver should be complying with the
Datasheet. I think it's a "Bug" and not a "Feature" that the Image
gets sharpened but more grainy when not setting this bit.

Furthermore, I have opened a Ticket at ADV to get more details, but
I'm not really expecting a proper Answer.

Benjamin



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux