Hi Sergio, On Wednesday 21 July 2010 18:33:54 Aguirre, Sergio wrote: > Hi Laurent, > > > -----Original Message----- > > From: Laurent Pinchart [mailto:laurent.pinchart@xxxxxxxxxxxxxxxx] > > Sent: Tuesday, June 29, 2010 5:23 AM > > To: Aguirre, Sergio > > Cc: Sakari Ailus; linux-media@xxxxxxxxxxxxxxx > > Subject: Re: [media-ctl] [omap3camera:devel] How to use the app? > > <snip> > > > You will find a set of patches that remove the legacy video nodes attached > > to this e-mail. They haven't been applied to the omap3camera tree yet, as > > we still haven't fixed all userspace components yet, but they should get > > there in a few weeks hopefully. You should probably apply them to your > > tree to make sure you don't start using the legacy video nodes by mistake. > > They also remove a lot of code, which is always good, and remove the > > hardcoded number of sensors. > > By any chance, do you keep rebasing these patches in a branch somewhere? Yes. I keep rebasing them in my local tree. That's not very helpful for you though :-) > I tried rebasing them against latest 'devel' branch, but they fail on > omap34xxcam.c, because the removed content is not the same. The delta is > just an addition you did to reset all non-legacy links during init. > > Is it ok to still remove this completely? Or is this going to be rellocated > somewhere? > > The patch I'm talking about is named: "omap34xxcam: Reset all links before > setting up the pipeline". It's OK to remove that completely. I've attached an updated version of the patches rebased on top of the latest omap3camera devel branch to this e-mail. Sakari, would it be possible to commit them to a legacy-removal branch in the omap3camera tree ? They would need to be rebased regularly, but they're not expected to change a much. -- Regards, Laurent Pinchart
Attachment:
legacy-removal-patches.tar.bz2
Description: application/bzip-compressed-tar