Hi Geert,
Thanks for the feedback.
> Subject: Re: [PATCH v10 2/5] media: renesas: vsp1: Add support to
> deassert/assert reset line
>
> Hi Biju,
>
> On Wed, May 4, 2022 at 9:06 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> > As the resets DT property is mandatory, and is present in all .dtsi in
> > mainline, add support to perform deassert/assert using reference
> > counted reset handle.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > Reviewed-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> > ---
> > v9->v10:
> > * Moved {deassert,assert} calls to vsp1_pm_runtime_{resume,suspend}
>
> Thanks for the update!
>
> > --- a/drivers/media/platform/renesas/vsp1/vsp1_drv.c
> > +++ b/drivers/media/platform/renesas/vsp1/vsp1_drv.c
> > @@ -631,13 +633,21 @@ static int __maybe_unused
> vsp1_pm_runtime_resume(struct device *dev)
> > struct vsp1_device *vsp1 = dev_get_drvdata(dev);
> > int ret;
> >
> > + ret = reset_control_deassert(vsp1->rstc);
> > + if (ret < 0)
> > + return ret;
> > +
> > if (vsp1->info) {
> > ret = vsp1_device_init(vsp1);
> > if (ret < 0)
>
> Missing reset_control_assert().
OK, will fix this, by adding goto statement, which can be used for below error
handling as well.
Cheers,
Biju
>
> > return ret;
> > }
> >
> > - return rcar_fcp_enable(vsp1->fcp);
> > + ret = rcar_fcp_enable(vsp1->fcp);
> > + if (ret < 0)
> > + reset_control_assert(vsp1->rstc);
> > +
> > + return ret;
> > }
> >
> > static const struct dev_pm_ops vsp1_pm_ops = {
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
> -- Linus Torvalds
