Argh - I screwed up a rebase here, not sure how I missed that. Sorry all, let me resend On 05/05/2022 02:02, kernel test robot wrote: > Hi Daniel, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on media-tree/master] > [also build test WARNING on v5.18-rc5 next-20220504] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/intel-lab-lkp/linux/commits/Daniel-Scally/Support-OVTI7251-on-Microsoft-Surface-line/20220505-063608 > base: git://linuxtv.org/media_tree.git master > config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20220505/202205050844.k1CPWqtV-lkp@xxxxxxxxx/config) > compiler: m68k-linux-gcc (GCC) 11.3.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/intel-lab-lkp/linux/commit/132a5a799bbe214b679bc8e242193c5c1ff1d967 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Daniel-Scally/Support-OVTI7251-on-Microsoft-Surface-line/20220505-063608 > git checkout 132a5a799bbe214b679bc8e242193c5c1ff1d967 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/media/i2c/ > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > All warnings (new ones prefixed by >>): > > drivers/media/i2c/ov7251.c: In function 'ov7251_set_format': >>> drivers/media/i2c/ov7251.c:1218:25: warning: variable 'vblank_def' set but not used [-Wunused-but-set-variable] > 1218 | int vblank_max, vblank_def; > | ^~~~~~~~~~ > At top level: > drivers/media/i2c/ov7251.c:193:37: warning: 'ov7251_pll1_cfg_24_mhz_319_2_mhz' defined but not used [-Wunused-const-variable=] > 193 | static const struct ov7251_pll1_cfg ov7251_pll1_cfg_24_mhz_319_2_mhz = { > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > vim +/vblank_def +1218 drivers/media/i2c/ov7251.c > > 1211 > 1212 static int ov7251_set_format(struct v4l2_subdev *sd, > 1213 struct v4l2_subdev_state *sd_state, > 1214 struct v4l2_subdev_format *format) > 1215 { > 1216 struct ov7251 *ov7251 = to_ov7251(sd); > 1217 struct v4l2_mbus_framefmt *__format; >> 1218 int vblank_max, vblank_def; > 1219 struct v4l2_rect *__crop; > 1220 const struct ov7251_mode_info *new_mode; > 1221 int ret = 0; > 1222 > 1223 mutex_lock(&ov7251->lock); > 1224 > 1225 __crop = __ov7251_get_pad_crop(ov7251, sd_state, format->pad, > 1226 format->which); > 1227 > 1228 new_mode = v4l2_find_nearest_size(ov7251_mode_info_data, > 1229 ARRAY_SIZE(ov7251_mode_info_data), > 1230 width, height, > 1231 format->format.width, format->format.height); > 1232 > 1233 __crop->width = new_mode->width; > 1234 __crop->height = new_mode->height; > 1235 > 1236 if (format->which == V4L2_SUBDEV_FORMAT_ACTIVE) { > 1237 ret = __v4l2_ctrl_modify_range(ov7251->exposure, > 1238 1, new_mode->exposure_max, > 1239 1, new_mode->exposure_def); > 1240 if (ret < 0) > 1241 goto exit; > 1242 > 1243 ret = __v4l2_ctrl_s_ctrl(ov7251->exposure, > 1244 new_mode->exposure_def); > 1245 if (ret < 0) > 1246 goto exit; > 1247 > 1248 ret = __v4l2_ctrl_s_ctrl(ov7251->gain, 16); > 1249 if (ret < 0) > 1250 goto exit; > 1251 > 1252 vblank_max = OV7251_TIMING_MAX_VTS - new_mode->height; > 1253 vblank_def = new_mode->vts - new_mode->height; > 1254 ret = __v4l2_ctrl_modify_range(ov7251->vblank, > 1255 OV7251_TIMING_MIN_VTS, > 1256 vblank_max, 1, vblank_max); > 1257 if (ret < 0) > 1258 goto exit; > 1259 > 1260 ov7251->current_mode = new_mode; > 1261 } > 1262 > 1263 __format = __ov7251_get_pad_format(ov7251, sd_state, format->pad, > 1264 format->which); > 1265 __format->width = __crop->width; > 1266 __format->height = __crop->height; > 1267 __format->code = MEDIA_BUS_FMT_Y10_1X10; > 1268 __format->field = V4L2_FIELD_NONE; > 1269 __format->colorspace = V4L2_COLORSPACE_SRGB; > 1270 __format->ycbcr_enc = V4L2_MAP_YCBCR_ENC_DEFAULT(__format->colorspace); > 1271 __format->quantization = V4L2_MAP_QUANTIZATION_DEFAULT(true, > 1272 __format->colorspace, __format->ycbcr_enc); > 1273 __format->xfer_func = V4L2_MAP_XFER_FUNC_DEFAULT(__format->colorspace); > 1274 > 1275 format->format = *__format; > 1276 > 1277 exit: > 1278 mutex_unlock(&ov7251->lock); > 1279 > 1280 return ret; > 1281 } > 1282 >
