Re: [PATCH v4 1/5] V4L2: Add seek spacing and FM RX class.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.


On Tue, 2010-07-06 at 04:03 +0200, ext Mauro Carvalho Chehab wrote:
> Em 04-06-2010 07:34, Matti J. Aaltonen escreveu:
> > +
> > +#define V4L2_CID_FM_RX_BAND			(V4L2_CID_FM_TX_CLASS_BASE + 1)
> > +enum v4l2_fm_rx_band {
> > +	V4L2_FM_BAND_OTHER		= 0,
> > +	V4L2_FM_BAND_JAPAN		= 1,
> > +	V4L2_FM_BAND_OIRT		= 2
> > +};
> 
> 
> You don't need anything special to define the bandwidth. VIDIOC_G_TUNER/VIDIOC_S_TUNER allows
> negotiating rangelow/rangehigh.

I don't quite get how you want this to be done... Are you saying that
this enum should not be there? At least the wl1273 chip actually
supports two bands so it would seem more straightforward to start by
defining the band and working from there than the other way round. 

B.R. 
Matti A.

> 
> > +
> >  /*
> >   *	T U N I N G
> >   */
> > @@ -1377,7 +1389,8 @@ struct v4l2_hw_freq_seek {
> >  	enum v4l2_tuner_type  type;
> >  	__u32		      seek_upward;
> >  	__u32		      wrap_around;
> > -	__u32		      reserved[8];
> > +	__u32		      spacing;
> > +	__u32		      reserved[7];
> >  };
> >  
> >  /*
> 
> I can't comment on your other API proposals, as you didn't send a patch documenting it
> at the API spec.
> 
> Cheers,
> Mauro.


--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux