Hello and thanks for the comments Mauro... One quick comment: On Tue, 2010-07-06 at 04:34 +0200, ext Mauro Carvalho Chehab wrote: > > + core->rx_frequency = > > + bands[core->band].bottom_frequency + > > + freq * 50; > > + > > + /* > > + * The driver works better with this msleep, > > + * the documentation doesn't mention it. > > + */ > > + msleep(10); > > > msleep on an irq handler? You shouldn't be doing it! You're not allowed to sleep > during IRQ time. Kernel can panic here. You'll probably need to defer work and > handle it outside irq time. This is not the IRQ handler, this is the irq thread function. > > + > > + r = request_threaded_irq(client->irq, NULL, > > + wl1273_fm_irq_thread_handler, > > + IRQF_ONESHOT | IRQF_TRIGGER_FALLING, > > + "wl1273-fm", core); B.R. Matti A. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
