Hi Geert,
Thanks for the feedback.
> Subject: Re: [PATCH v7 1/3] media: dt-bindings: media: renesas,vsp1:
> Document RZ/{G2L,V2L} VSPD bindings To: Mauro Carvalho Chehab
> <mchehab@xxxxxxxxxx>, Rob Herring <robh+dt@xxxxxxxxxx>, Krzysztof Kozlowski
> <krzk+dt@xxxxxxxxxx>
>
> Hi Biju,
>
> On Thu, Apr 14, 2022 at 4:26 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> wrote:
> > Document VSPD found in RZ/G2L and RZ/V2L family SoC's. VSPD block is
> > similar to VSP2-D found on R-Car SoC's, but it does not have a version
> > register and it has 3 clocks compared to 1 clock on vsp1 and vsp2.
> >
> > This patch introduces a new compatible 'renesas,rzg2l-vsp2' to handle
> > these differences.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml
> > +++ b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml
> > @@ -19,6 +19,7 @@ properties:
> > enum:
> > - renesas,vsp1 # R-Car Gen2 and RZ/G1
> > - renesas,vsp2 # R-Car Gen3 and RZ/G2
> > + - renesas,rzg2l-vsp2 # RZ/G2L and RZ/V2L
>
> Given there is no version register, probably you want to define SoC-
> specific compatible values.
Yes, that is the plan which is in line with Kieran's suggestion.
Cheers,
Biju
