Hi Sergio, Thanks for the review. On Thursday 15 July 2010 16:16:44 Aguirre, Sergio wrote: > > On Wednesday 14 July 2010 08:30:00 Laurent Pinchart wrote: <snip> > > diff --git a/include/media/media-device.h b/include/media/media-device.h > > new file mode 100644 > > index 0000000..6c1fc4a > > --- /dev/null > > +++ b/include/media/media-device.h > > @@ -0,0 +1,53 @@ [snip] > > +#ifndef _MEDIA_DEVICE_H > > +#define _MEDIA_DEVICE_H > > + > > +#include <linux/device.h> > > +#include <linux/list.h> > > + > > +#include <media/media-devnode.h> > > + > > +/* Each instance of a media device should create the media_device struct, > > + * either stand-alone or embedded in a larger struct. > > + * > > + * It allows easy access to sub-devices (see v4l2-subdev.h) and provides > > + * basic media device-level support. > > + */ > > + > > +#define MEDIA_DEVICE_NAME_SIZE (20 + 16) > > Where does above numbers come from ?? Copied from v4l2-device.h. It was originally BUS_ID_SIZE (the constant is now gone) + 16. I can replace that by a hardcoded 32. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
