Hi Laurent, Very minor comment below. > -----Original Message----- > From: linux-media-owner@xxxxxxxxxxxxxxx [mailto:linux-media- > owner@xxxxxxxxxxxxxxx] On Behalf Of Laurent Pinchart > Sent: Wednesday, July 14, 2010 8:30 AM > To: linux-media@xxxxxxxxxxxxxxx > Cc: sakari.ailus@xxxxxxxxxxxxxxxxxxxxxxxxxx > Subject: [RFC/PATCH 02/10] media: Media device > > The media_device structure abstracts functions common to all kind of > media devices (v4l2, dvb, alsa, ...). It manages media entities and > offers a userspace API to discover and configure the media device > internal topology. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > Documentation/media-framework.txt | 68 ++++++++++++++++++++++++++++++++ > drivers/media/Makefile | 2 +- > drivers/media/media-device.c | 77 > +++++++++++++++++++++++++++++++++++++ > include/media/media-device.h | 53 +++++++++++++++++++++++++ > 4 files changed, 199 insertions(+), 1 deletions(-) > create mode 100644 Documentation/media-framework.txt > create mode 100644 drivers/media/media-device.c > create mode 100644 include/media/media-device.h > <snip> > diff --git a/include/media/media-device.h b/include/media/media-device.h > new file mode 100644 > index 0000000..6c1fc4a > --- /dev/null > +++ b/include/media/media-device.h > @@ -0,0 +1,53 @@ > +/* > + * Media device support header. > + * > + * Copyright (C) 2010 Laurent Pinchart > <laurent.pinchart@xxxxxxxxxxxxxxxx> > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 > USA > + */ > + > +#ifndef _MEDIA_DEVICE_H > +#define _MEDIA_DEVICE_H > + > +#include <linux/device.h> > +#include <linux/list.h> > + > +#include <media/media-devnode.h> > + > +/* Each instance of a media device should create the media_device struct, > + * either stand-alone or embedded in a larger struct. > + * > + * It allows easy access to sub-devices (see v4l2-subdev.h) and provides > + * basic media device-level support. > + */ > + > +#define MEDIA_DEVICE_NAME_SIZE (20 + 16) Where does above numbers come from ?? Regards, Sergio > + > +struct media_device { > + /* dev->driver_data points to this struct. > + * Note: dev might be NULL if there is no parent device > + * as is the case with e.g. ISA devices. > + */ > + struct device *dev; > + struct media_devnode devnode; > + > + /* unique device name, by default the driver name + bus ID */ > + char name[MEDIA_DEVICE_NAME_SIZE]; > +}; > + > +int __must_check media_device_register(struct media_device *mdev); > +void media_device_unregister(struct media_device *mdev); > + > +#endif > -- > 1.7.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html