On 3/9/22 16:20, Dan Carpenter wrote: > On Wed, Mar 09, 2022 at 02:33:20PM +0100, Hans Verkuil wrote: >> Hi Dan, >> >> On 3/9/22 11:43, Dan Carpenter wrote: >>> Hello Ming Qian, >>> >>> The patch 9f599f351e86: "media: amphion: add vpu core driver" from >>> Feb 24, 2022, leads to the following Smatch static checker warning: >>> >>> drivers/media/platform/amphion/vpu_core.c:654 vpu_core_probe() >>> warn: pm_runtime_get_sync() also returns 1 on success >> >> Odd, I didn't get this warning when I ran smatch. > > Sorry, I will push this Smatch check tomorrow. It's simple and has few > false positives. Ah! I suddenly feel a lot less guilty for having missed this issue in the amphion driver :-) Looking forward to this new check! Regards, Hans
