Hi Dan, On 3/9/22 11:43, Dan Carpenter wrote: > Hello Ming Qian, > > The patch 9f599f351e86: "media: amphion: add vpu core driver" from > Feb 24, 2022, leads to the following Smatch static checker warning: > > drivers/media/platform/amphion/vpu_core.c:654 vpu_core_probe() > warn: pm_runtime_get_sync() also returns 1 on success Odd, I didn't get this warning when I ran smatch. I'm running smatch from the master branch of git://repo.or.cz/smatch.git. To be honest, I don't see the string 'also returns' at all in the git repo. I'd really like to see this warning since it's so easy to get pm_runtime_get_sync() wrong, and to miss it as a reviewer as well. Regards, Hans
