Hi Laurent, On Sun, Jan 23, 2022 at 01:48:16AM +0200, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Sat, Jan 22, 2022 at 06:36:55PM +0200, Sakari Ailus wrote: > > Set bus_info field based on struct device in media_device_init(). Also > > remove corresponding code from drivers. > > This looks fine to me, but the documentation should be updated to > explain that bus_info will be set by media_device_init(), and that > driver may then override the value if desired (and probably also list > the rules under which such an override is allowed). We haven't really documented that for other fields either and rather relied more on examples. I can add that if you still think so though. -- Sakari Ailus
