On Sun, Jan 16, 2022 at 11:52 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > Hi All, > > Here is a patch series fixing various bugs in the current > atomisp_gmin_platform AXP288 support (it was completely broken before > this series) as well as adding support for devices with front and back > sensors. > > This has been tested on a Teclast Tbook11 and a > Trekstor Surftab Duo W1 10.1, both of which use ov2680 sensors as both > there front and back sensors. > > I think this should also make things work on the Cyberbook T116, > but I did not get around to testing that yet. > > This series also contains some code to try and get things to work on > Bay Trail devices. This at least makes the driver load, but it does > not work yet and actually getting it to work may very well be quite > tricky. Thanks for the series! I have looked into all patches and I found them clean and good. Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > Regards, > > Hans > > > Hans de Goede (9): > media: atomisp: Don't use ifdef on IS_ISP2401 > media: atomisp: Don't use ifdef ISP2400 > media: atomisp: Use irci_stable_candrpv_0415_20150423_1753 fw for byt > media: atomisp_gmin_platform: Fix axp_regulator_set() writing to the > wrong register > media: atomisp_gmin_platform: Add enable-count to > gmin_[v1p8|v2p8]_ctrl() > media: atomisp_gmin_platform: Set ELDO1 to 1.6V on devices with an > AXP288 PMIC > media: atomisp_gmin_platform: Do not turn ELDO2 off from axp_v1p8_on() > media: atomisp_gmin_platform: Base CsiPort default on detected CLK > media: atomisp_gmin_platform: Add DMI quirk to not turn AXP ELDO2 > regulator off on some boards > > .../media/atomisp/pci/atomisp_compat_css20.c | 4 +- > .../media/atomisp/pci/atomisp_gmin_platform.c | 148 +++++++++++++----- > .../staging/media/atomisp/pci/atomisp_v4l2.c | 2 +- > .../media/atomisp/pci/sh_css_firmware.c | 4 + > 4 files changed, 114 insertions(+), 44 deletions(-) > > -- > 2.33.1 > -- With Best Regards, Andy Shevchenko