Em Thu, 9 Dec 2021 20:37:29 +0100 Robert Schlabbach <robert_s@xxxxxxx> escreveu: > > Not true. if you check the code for si2148, it doesn't have > > an option to skip firmware load. > > You're right. I thought I had checked all code, but I must have > missed that one. > > Or I was distracted by the fact that for Si2148 with romid 0x33, > a "dummy patch" is used, which according to the code comment > skips the firmware download and boots from NVM only. So I suppose > that version does not actually need the firmware...?!? That's a good question. It sounds funny to have a "dummy patch" loaded that would "skip firmware download", as the same would happen without a firmware patch :-) Hard to know for sure, but maybe the comment there was just outdated. E. g. on a previous release it would have the code below such comment also commented, but a new patch was then added, but someone forgot to remove the comments. > > I can't see a request_firmware_nowarn() function > > Sorry, it's: > > EXPORT_SYMBOL_GPL(firmware_request_nowarn); Ah ;-) > They swapped the words around vs. the original function, for > whatever reason. Anyway, please use "firmware_request_nowarn()" > which does not log any message when the file is not found, so > that only the message logged from the si2157 shows up in the > kernel log. Yeah, makes sense, especially since we'll be trying to load two firmware files, at least for some of the tuners. Thanks, Mauro
