As pointed bt Robert, if there's already a firmware for si2157 at /lib/firmware, it is preferred to use it, instead of the default firmware. Yet, when this is missed, the driver may still work. That's the case, for instance, of the devices explicitly flagged with dont_load_firmware (currently, Terratec Cinergy TC2). So, rework the firmware logic in a way that it will emit a warning for devices that are using the eeprom firmware and may not work well with it. Robert, This was compile-tested only. Could you please test it on your device? Mauro Carvalho Chehab (2): media: si2157: move firmware load to a separate function media: si2157: rework the firmware load logic Robert Schlabbach (1): media: si2157: Add optional firmware download drivers/media/tuners/si2157.c | 120 +++++++++++++++++++++------------- 1 file changed, 75 insertions(+), 45 deletions(-) -- 2.33.1
