Re: [PATCH] [media] s5c73m3: Drop empty spi_driver remove callback

Andrzej Hajda <andrzej.hajda@xxxxxxxxx> · Thu, 21 Oct 2021 16:08:38 +0200

On 21.10.2021 13:10, Kieran Bingham wrote:
- To: Updated Andrzej's e-mail address
Thx for update :)

Quoting Uwe Kleine-König (2021-10-21 07:25:47)
A driver with a remove callback that just returns 0 behaves identically
to a driver with no remove callback at all. So simplify accordingly.
Looks fine to me though.

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>


Reviewed-by: Andrzej Hajda <andrzej.hajda@xxxxxxxxx>

Regards

Andrzej


Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
---
  drivers/media/i2c/s5c73m3/s5c73m3-spi.c | 6 ------
  1 file changed, 6 deletions(-)

diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-spi.c b/drivers/media/i2c/s5c73m3/s5c73m3-spi.c
index c102c6bbc118..7fe61187a2f8 100644
--- a/drivers/media/i2c/s5c73m3/s5c73m3-spi.c
+++ b/drivers/media/i2c/s5c73m3/s5c73m3-spi.c
@@ -130,16 +130,10 @@ static int s5c73m3_spi_probe(struct spi_device *spi)
         return 0;
  }
  
-static int s5c73m3_spi_remove(struct spi_device *spi)
-{
-       return 0;
-}
-
  int s5c73m3_register_spi_driver(struct s5c73m3 *state)
  {
         struct spi_driver *spidrv = &state->spidrv;
  
-       spidrv->remove = s5c73m3_spi_remove;
         spidrv->probe = s5c73m3_spi_probe;
         spidrv->driver.name = S5C73M3_SPI_DRV_NAME;
         spidrv->driver.of_match_table = s5c73m3_spi_ids;
--
2.30.2







