- To: Updated Andrzej's e-mail address
Quoting Uwe Kleine-König (2021-10-21 07:25:47)
> A driver with a remove callback that just returns 0 behaves identically
> to a driver with no remove callback at all. So simplify accordingly.
Looks fine to me though.
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> ---
> drivers/media/i2c/s5c73m3/s5c73m3-spi.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-spi.c b/drivers/media/i2c/s5c73m3/s5c73m3-spi.c
> index c102c6bbc118..7fe61187a2f8 100644
> --- a/drivers/media/i2c/s5c73m3/s5c73m3-spi.c
> +++ b/drivers/media/i2c/s5c73m3/s5c73m3-spi.c
> @@ -130,16 +130,10 @@ static int s5c73m3_spi_probe(struct spi_device *spi)
> return 0;
> }
>
> -static int s5c73m3_spi_remove(struct spi_device *spi)
> -{
> - return 0;
> -}
> -
> int s5c73m3_register_spi_driver(struct s5c73m3 *state)
> {
> struct spi_driver *spidrv = &state->spidrv;
>
> - spidrv->remove = s5c73m3_spi_remove;
> spidrv->probe = s5c73m3_spi_probe;
> spidrv->driver.name = S5C73M3_SPI_DRV_NAME;
> spidrv->driver.of_match_table = s5c73m3_spi_ids;
> --
> 2.30.2
>
