Hi Qing, Quoting Qing Wang (2021-10-20 03:14:15) > show() should not use snprintf() when formatting the value to be > returned to user space. > > Fix the following coccicheck warning: > drivers/media/i2c/ccs/ccs-core.c:3761: WARNING: use scnprintf or sprintf. > > V3: > - Fix some formatting problems. This could go below the --- so that it doesn't get entered into the commit itself, but I suspect that can be handled while applying. Not sure what the preferences are for that. Anyway, thank you for updating with my suggestions. Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> > > Signed-off-by: Qing Wang <wangqing@xxxxxxxx> > --- > drivers/media/i2c/ccs/ccs-core.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/media/i2c/ccs/ccs-core.c b/drivers/media/i2c/ccs/ccs-core.c > index 5363f3b..9158d3c > --- a/drivers/media/i2c/ccs/ccs-core.c > +++ b/drivers/media/i2c/ccs/ccs-core.c > @@ -2758,13 +2758,13 @@ ident_show(struct device *dev, struct device_attribute *attr, char *buf) > struct ccs_module_info *minfo = &sensor->minfo; > > if (minfo->mipi_manufacturer_id) > - return snprintf(buf, PAGE_SIZE, "%4.4x%4.4x%2.2x\n", > - minfo->mipi_manufacturer_id, minfo->model_id, > - minfo->revision_number) + 1; > + return sysfs_emit(buf, "%4.4x%4.4x%2.2x\n", > + minfo->mipi_manufacturer_id, minfo->model_id, > + minfo->revision_number) + 1; > else > - return snprintf(buf, PAGE_SIZE, "%2.2x%4.4x%2.2x\n", > - minfo->smia_manufacturer_id, minfo->model_id, > - minfo->revision_number) + 1; > + return sysfs_emit(buf, "%2.2x%4.4x%2.2x\n", > + minfo->smia_manufacturer_id, minfo->model_id, > + minfo->revision_number) + 1; > } > static DEVICE_ATTR_RO(ident); > > -- > 2.7.4 >
