Re: [PATCH v5] media: rcar-isp: Add Renesas R-Car Image Signal Processor driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

On 2021-10-04 13:28:07 +0300, Sakari Ailus wrote:
> Hi Hans, Niklas,
> 
> On Mon, Oct 04, 2021 at 11:11:55AM +0200, Hans Verkuil wrote:
> > > +	isp->subdev.entity.function = MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER;
> > 
> > Is this correct? Based on the description it is really more a MEDIA_ENT_F_VID_MUX.
> 
> We also have MEDIA_ENT_F_PROC_VIDEO_ISP nowadays. Just a note. But VID_MUX
> would seem appropriate based on what it appears to be doing.
> 
> Niklas: what does the device do with the data other than redirect it to
> some of its outputs?

It have other ISP capabilities. I would love to extend the driver to 
support it, but the documentation I have only covers whats in this 
driver, muxing. I don't suspect this will change so I agree VID_MUX make 
most sens.

> 
> -- 
> Sakari Ailus

-- 
Regards,
Niklas Söderlund



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux