Hi Hans, Niklas, On Mon, Oct 04, 2021 at 11:11:55AM +0200, Hans Verkuil wrote: > > + isp->subdev.entity.function = MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER; > > Is this correct? Based on the description it is really more a MEDIA_ENT_F_VID_MUX. We also have MEDIA_ENT_F_PROC_VIDEO_ISP nowadays. Just a note. But VID_MUX would seem appropriate based on what it appears to be doing. Niklas: what does the device do with the data other than redirect it to some of its outputs? -- Sakari Ailus