Hi Sakari, Thank you for, I was not aware of that! Will add this to this driver. Thanks, BRs, Arec Kao -----Original Message----- From: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> Sent: Friday, August 13, 2021 10:31 PM To: Kao, Arec <arec.kao@xxxxxxxxx> Cc: linux-media@xxxxxxxxxxxxxxx; Yeh, Andy <andy.yeh@xxxxxxxxx>; Chang, Wei Shun <wei.shun.chang@xxxxxxxxx> Subject: Re: [PATCH v2] Add sensor driver support for the ov13b10 camera. Hi Arec, On Fri, Aug 13, 2021 at 04:18:45PM +0800, Arec Kao wrote: > This driver supports following features: > > - phase detection auto focus (PDAF) > - manual exposure and analog/digital gain control > - vblank/hblank control > - test pattern > - image vertical flip and horizontal mirror control > - 4208x3120 at 30FPS > - 2080x1170 at 60FPS Forgot a few things on v2... I noticed the driver doesn't check the link frequency used by the driver at the moment is valid for the given board. Could you add that? See e.g. drivers/media/i2c/imx319.c for an example. Also an entry in MAINTAINERS is needed, see e.g. one for IMX319 again. -- Kind regards, Sakari Ailus
