Hi Arec, On Fri, Aug 13, 2021 at 04:18:45PM +0800, Arec Kao wrote: > This driver supports following features: > > - phase detection auto focus (PDAF) > - manual exposure and analog/digital gain control > - vblank/hblank control > - test pattern > - image vertical flip and horizontal mirror control > - 4208x3120 at 30FPS > - 2080x1170 at 60FPS Forgot a few things on v2... I noticed the driver doesn't check the link frequency used by the driver at the moment is valid for the given board. Could you add that? See e.g. drivers/media/i2c/imx319.c for an example. Also an entry in MAINTAINERS is needed, see e.g. one for IMX319 again. -- Kind regards, Sakari Ailus