On Mon, Aug 9, 2021 at 8:31 PM Hans Verkuil <hverkuil-cisco@xxxxxxxxx> wrote: > I made a PR for this series, but I would like a follow-up patch that fixes this > sparse warning: > > SPARSE:mtk-vcodec/mtk_vcodec_dec_stateful.c:615:35: warning: symbol 'mtk_vdec_8173_pdata' was not declared. Should it be static? > SPARSE:mtk-vcodec/mtk_vcodec_dec_stateless.c:346:35: warning: symbol 'mtk_vdec_8183_pdata' was not declared. Should it be static? > > mtk_vcodec_dec.h is probably a good header to put the extern declaration. The follow up fix: https://patchwork.linuxtv.org/project/linux-media/list/?series=6066