On 24/06/2021 09:40, Sakari Ailus wrote:
> From: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
>
> The fwnode is retrieved using fwnode_graph_get_endpoint_by_id() without
> the FWNODE_GRAPH_DEVICE_DISABLED flag set. So there is no need to
> explicitly check if the fwnode is available as it always will be when
> the check is performed, remove it.
Interestingly I don't see any users of FWNODE_GRAPH_DEVICE_DISABLED ...
I guess it's just there in case someone does one day need it.
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> Reviewed-by: Jacopo Mondi <jacopo@xxxxxxxxxx>
> ---
> drivers/media/platform/rcar-vin/rcar-core.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/media/platform/rcar-vin/rcar-core.c b/drivers/media/platform/rcar-vin/rcar-core.c
> index 3b7052ff7117..a24aeda37e74 100644
> --- a/drivers/media/platform/rcar-vin/rcar-core.c
> +++ b/drivers/media/platform/rcar-vin/rcar-core.c
> @@ -834,13 +834,6 @@ static int rvin_mc_parse_of(struct rvin_dev *vin, unsigned int id)
> goto out;
> }
>
> - if (!of_device_is_available(to_of_node(fwnode))) {
> - vin_dbg(vin, "OF device %pOF disabled, ignoring\n",
> - to_of_node(fwnode));
> - ret = -ENOTCONN;
> - goto out;
> - }
> -
> asd = v4l2_async_nf_add_fwnode(&vin->group->notifier, fwnode,
> struct v4l2_async_subdev);
> if (IS_ERR(asd)) {
>
