Kieran,
On 5/17/21 7:13 PM, Kieran Bingham wrote:
> Hi Ariel,
>
> On 17/05/2021 21:55, Ariel D'Alessandro wrote:
>> Hi Kieran!
>>
>> Thanks a lot for the feedback.
>
> No worries, somehow this is almost fun to test out (mostly because of
> watching how crazy fast it is building in meson in comparison).
>
>
>> On 5/13/21 5:56 AM, Kieran Bingham wrote:
>>> Hi Ariel,
[Omitting as there's further discussion in other mail responses from
this same thread.]
>
> The next step was to install both versions, as that will compare what's
> actually built and results in the package, and in fact they do look
> quite similar.
>
> There are a few small changes, that might be worth looking into - but I
> don't think there's any major difference in what is or isn't built.
> (unless the Internationalisation stuff really is the major factor)
>
> - Spurious meson.build file is being installed at
> /lib/udev/rc_keymaps/meson.build
Will be fixed by:
diff --git a/utils/keytable/Makefile.am b/utils/keytable/Makefile.am
index d3edcf77..deb13934 100644
--- a/utils/keytable/Makefile.am
+++ b/utils/keytable/Makefile.am
@@ -1,7 +1,7 @@
bin_PROGRAMS = ir-keytable
man_MANS = ir-keytable.1 rc_keymap.5
sysconf_DATA = rc_maps.cfg
-keytablesystem_DATA = $(srcdir)/rc_keymaps/*
+keytablesystem_DATA = $(srcdir)/rc_keymaps/*.toml
udevrules_DATA = 70-infrared.rules
if WITH_BPF
if HAVE_SYSTEMD
>
> - Meson decided to default libdir to
> /usr/local/lib/x86_64-linux-gnu
> while autoconf used
> /usr/local/lib
> (it's likely handled by the package managers anyway)
$ meson configure ../build-meson/ | grep libdir
libdir lib/x86_64-linux-gnu Library directory
Package manager should run meson with configuration option
`-Dlibdir=lib`. Will document this.
>
> - /usr/local/etc/rc_keymaps/protocols
> was installed though autoconf didn't ?
I don't get that difference. Maybe it's related to a different set of
features detected by the two build systems?
>
> - Autoconf seemed to install v4l1compat.so and v4l2convert.so
> (possibly in duplicate) in the libdir, as well as in libdir/libv4l/
> I'm not sure if that's a bug or a feature in autoconf
Right, an extra symlink is being added to those libs. Is this really needed?
>
> Ah, and again - size of those installs looks quite different suggesting
> (probably that localisation) has differed between the two builds quite
> drastically
>
> (after DESTDIR=/tmp/v4l2-$BUILDSYSTEM {make, ninja} install)
>
>
> du -sh /tmp/v4l2-autoconf/ /tmp/v4l2-meson/
> 39M /tmp/v4l2-autoconf/
> 22M /tmp/v4l2-meson/
As mentioned in another response. Autotools is building with `-g -O2` by
default, that'd the equivalent meson configuration option
--buildtype=debugoptimized. With this configuration the installtion
sizes are not that different:
$ du -s installation_m*
37068 installation_make
37848 installation_meson
In this case the difference is related to libtool `.la` files not being
generated by meson and gconv/ only installed by meson. The latest is
probably a feature being only detected by meson in this case, will check
that out.
~/dev/v4l$ diff -r files_make files_meson
233a234,236
> ./usr/local/lib/gconv/ARIB-STD-B24.so
> ./usr/local/lib/gconv/EN300-468-TAB00.so
> ./usr/local/lib/gconv/gconv-modules
235d237
< ./usr/local/lib/libdvbv5.la
238d239
< ./usr/local/lib/libv4l1.la
241d241
< ./usr/local/lib/libv4l2.la
243d242
< ./usr/local/lib/libv4l2rds.la
247d245
< ./usr/local/lib/libv4lconvert.la
251d248
< ./usr/local/lib/libv4l/plugins/libv4l-mplane.la
253d249
< ./usr/local/lib/libv4l/v4l1compat.la
255d250
< ./usr/local/lib/libv4l/v4l2convert.la
More soon,
Ariel
