On (21/05/26 12:38), Hans Verkuil wrote: > Hi Sergey, > > On 01/05/2021 10:19, Sergey Senozhatsky wrote: > > Hello, > > > > This patch set implements UVC 1.5 ROI using v4l2_selection API. > > > > v5: > > -- fixed UAPI typo: STABILIXATION > > -- moved V4L2_CID_REGION_OF_INTEREST_AUTO to V4L2_CID_CAMERA_CLASS_BASE+36 > > -- added more comments (Ricardo) > > -- added V4L2_CID_REGION_OF_INTEREST_AUTO to v4l2_ctrl_get_name() (Ricardo) > > > > Sergey Senozhatsky (5): > > media: v4l UAPI: add ROI selection targets > > As mentioned in my reply to v4 0/5, I am quite strongly opposed to using the > Selection API for this as opposed to using controls. Unless someone can provide > strong arguments for using the Selection API, I am inclined to reject this. > > Sorry about that, I probably should have been reviewing this series sooner. Hans, any suggestions regarding the UVCs GET_CUR, GET_DEF, GET_MIN/MAX requests handling?