Hi Sergey, On 01/05/2021 10:19, Sergey Senozhatsky wrote: > Hello, > > This patch set implements UVC 1.5 ROI using v4l2_selection API. > > v5: > -- fixed UAPI typo: STABILIXATION > -- moved V4L2_CID_REGION_OF_INTEREST_AUTO to V4L2_CID_CAMERA_CLASS_BASE+36 > -- added more comments (Ricardo) > -- added V4L2_CID_REGION_OF_INTEREST_AUTO to v4l2_ctrl_get_name() (Ricardo) > > Sergey Senozhatsky (5): > media: v4l UAPI: add ROI selection targets As mentioned in my reply to v4 0/5, I am quite strongly opposed to using the Selection API for this as opposed to using controls. Unless someone can provide strong arguments for using the Selection API, I am inclined to reject this. Sorry about that, I probably should have been reviewing this series sooner. Regards, Hans > media: v4l UAPI: document ROI selection targets > media: uvcvideo: add ROI auto controls > media: v4l UAPI: document ROI auto_controls > media: uvcvideo: add UVC 1.5 ROI control > > .../media/v4l/ext-ctrls-camera.rst | 23 +++ > .../media/v4l/selection-api-configuration.rst | 22 ++ > .../media/v4l/selection-api-examples.rst | 27 +++ > .../media/v4l/v4l2-selection-targets.rst | 24 +++ > drivers/media/usb/uvc/uvc_ctrl.c | 19 ++ > drivers/media/usb/uvc/uvc_v4l2.c | 189 +++++++++++++++++- > drivers/media/v4l2-core/v4l2-ctrls.c | 1 + > include/uapi/linux/usb/video.h | 1 + > include/uapi/linux/v4l2-common.h | 8 + > include/uapi/linux/v4l2-controls.h | 10 + > 10 files changed, 321 insertions(+), 3 deletions(-) >
