Hi Tomi,
Thank you for the patch.
On Tue, Apr 27, 2021 at 03:45:11PM +0300, Tomi Valkeinen wrote:
> Add a helper macro for iterating over pads that are connected through
> enabled routes. This can be used to find all the connected pads within an
> entity, for instance starting from the pad which has been obtained during
> the graph walk.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
>
> - Make __media_entity_next_routed_pad() return NULL and adjust the
> iterator to handle that
> Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>
> ---
> include/media/media-entity.h | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/include/media/media-entity.h b/include/media/media-entity.h
> index f8fa952fa38e..42193d6c58e9 100644
> --- a/include/media/media-entity.h
> +++ b/include/media/media-entity.h
> @@ -916,6 +916,34 @@ __must_check int media_graph_walk_init(
> bool media_entity_has_route(struct media_entity *entity, unsigned int pad0,
> unsigned int pad1);
>
> +static inline struct media_pad *__media_entity_next_routed_pad(
> + struct media_pad *start, struct media_pad *iter)
> +{
> + struct media_entity *entity = start->entity;
> +
> + for (; iter < &entity->pads[entity->num_pads]; iter++) {
> + if (media_entity_has_route(entity, start->index, iter->index))
> + return iter;
> + }
> +
> + return NULL;
> +}
> +
> +/**
> + * media_entity_for_each_routed_pad - Iterate over entity pads connected by routes
> + *
> + * @start: The starting pad
> + * @iter: The iterator pad
> + *
> + * Iterate over all pads connected through routes from the @start pad
> + * within an entity. The iteration will include the @start pad itself.
> + */
I still think a better name would be, well, better :-) Let's continue
the discussion in the v5 thread to avoid splitting it.
> +#define media_entity_for_each_routed_pad(start, iter) \
> + for (iter = __media_entity_next_routed_pad( \
> + start, (start)->entity->pads); \
> + iter != NULL; \
> + iter = __media_entity_next_routed_pad(start, iter + 1))
> +
> /**
> * media_graph_walk_cleanup - Release resources used by graph walk.
> *
--
Regards,
Laurent Pinchart
