On Fri, Apr 23, 2021 at 2:03 PM Ariel D'Alessandro <ariel.dalessandro@xxxxxxxxxxxxx> wrote: > > Hi Gregor, > > Following up on this patchset after some time. > > On 3/20/21 1:56 PM, Gregor Jasny wrote: > > Hello, > > > > Thank you again for these patches. Building v4l-utils has never been so > > fast and easy. It will accelerate my Debian / Ubuntu packaging and > > really sparks joy! > > Happy to see it being useful :-) > > > > > On 17.03.21 18:22, Ariel D'Alessandro wrote: > >> Supports building libraries and tools found in contrib/, lib/ and > >> utils/ directories, along with the implemented gettext translations. > > > > Here's a patch on top of your tree: > > https://gitlab.com/gjasny/v4l-utils/-/commit/a9853f79c2675bf08fc3e93f15aa4158c9769bdd > > > > > > I changed the following: > > * Use pkgconfig to detect libbpf (like configure.ac does) > > * check for libbpf presence in the keytable subdir (like it's done for > > libelf > > * refined the empty rc_keymaps dir hack with something supported by > > meson: https://github.com/mesonbuild/meson/issues/2904 (your hack > > stopped working for me with meson on Ubuntu 20.04.2) > [snip] > > Tested-by: Gregor Jasny <gjasny@xxxxxxxxxxxxxx> > > Thanks a lot for your changes! LGTM, I'll add these changes, test and > post a v5 asap. I recommend adding c_std=gnu99 and cpp_std=gnu++11 to default_options as otherwise compilation will fail with older compilers. gnu is needed. the C variants do not work. > > Ariel
