Re: Re: [PATCH] staging: media: atomisp: Removed a function entry log

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 12, 2021 at 11:28:09AM +0200, Hans Verkuil wrote:
> On 12/04/2021 04:35, Martiros Shakhzadyan wrote:
> > Coding style fix.
> 
> What exactly is the coding style issue? Please mention that.
> 
> Also, by removing the line you change the behavior (i.e. if debugging is
> enabled, you no longer see this message). That's more than a coding style
> fix...
> 
> Regards,
> 
> 	Hans
> 

Thank you, Hans - I will resubmit the patch with a better commit
message.

> > 
> > Signed-off-by: Martiros Shakhzadyan <vrzh@xxxxxxxx>
> > ---
> >  drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> > index c017e9066b7a..912eadaffc44 100644
> > --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> > +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> > @@ -1175,8 +1175,6 @@ static int ov2722_remove(struct i2c_client *client)
> >  	struct v4l2_subdev *sd = i2c_get_clientdata(client);
> >  	struct ov2722_device *dev = to_ov2722_sensor(sd);
> >  
> > -	dev_dbg(&client->dev, "ov2722_remove...\n");
> > -
> >  	dev->platform_data->csi_cfg(sd, 0);
> >  	v4l2_ctrl_handler_free(&dev->ctrl_handler);
> >  	v4l2_device_unregister_subdev(sd);
> > 
> 



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux