On Mon, Apr 12, 2021 at 11:40:48AM +0200, Jacopo Mondi wrote:
> Hi Martiros,
>
> On Sun, Apr 11, 2021 at 10:35:58PM -0400, Martiros Shakhzadyan wrote:
> > Fixed line continuation and parenthesis alignment issues.
> >
> > Signed-off-by: Martiros Shakhzadyan <vrzh@xxxxxxxx>
> >
> > squashme
>
> This line should probably be dropped :)
>
Oops! :)
> > ---
> > drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> > index 912eadaffc44..90a985ee25fa 100644
> > --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> > +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
> > @@ -49,8 +49,8 @@ static int ov2722_read_reg(struct i2c_client *client,
> > return -ENODEV;
> > }
> >
> > - if (data_length != OV2722_8BIT && data_length != OV2722_16BIT
> > - && data_length != OV2722_32BIT) {
> > + if (data_length != OV2722_8BIT && data_length != OV2722_16BIT &&
> > + data_length != OV2722_32BIT) {
>
> Does checkpatch report this one ?
>
It did. Once I moved `&&` on the previous line it stopped complaining.
> > dev_err(&client->dev, "%s error, invalid data length\n",
> > __func__);
> > return -EINVAL;
> > @@ -212,8 +212,8 @@ static int __ov2722_buf_reg_array(struct i2c_client *client,
> > }
> >
> > static int __ov2722_write_reg_is_consecutive(struct i2c_client *client,
> > - struct ov2722_write_ctrl *ctrl,
> > - const struct ov2722_reg *next)
> > + struct ov2722_write_ctrl *ctrl,
> > + const struct ov2722_reg *next)
>
> These are probably 2 separate changes, but give this is just a style
> fix I think it's ok...
>
> Reviewed-by: Jacopo Mondi <jacopo@xxxxxxxxxx>
>
>
>
Thanks for the review - will resubmit with a fixed commit message.
> > {
> > if (ctrl->index == 0)
> > return 1;
> > --
> > 2.31.1
> >
