Hi Rob, Thanks for reviewing. On Wed, 2021-03-24 at 09:17 -0600, Rob Herring wrote: > On Thu, Mar 11, 2021 at 03:40:51PM +0000, Emil Velikov wrote: > > From: Emil Velikov <emil.velikov@xxxxxxxxxxxxx> > > > > Add devicetree binding documentation for the Hantro G1/G2 VDEC on > > the Microchip SAMAS5D4 SoC. > > > > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > > Cc: Frank Rowand <frowand.list@xxxxxxxxx> > > Cc: devicetree@xxxxxxxxxxxxxxx> > > Signed-off-by: Emil Velikov <emil.velikov@xxxxxxxxxxxxx> > > --- > > v2 > > - Newly introduced > > - s/Atmel/Microchip/ (Nicolas) > > - Drop leading 0 in node name/address > > --- > > .../media/microchip,sama5d4-vdec.yaml | 59 +++++++++++++++++++ > > 1 file changed, 59 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/microchip,sama5d4-vdec.yaml > > > > diff --git a/Documentation/devicetree/bindings/media/microchip,sama5d4-vdec.yaml b/Documentation/devicetree/bindings/media/microchip,sama5d4- > > vdec.yaml > > new file mode 100644 > > index 000000000000..9cb2c0295d54 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/microchip,sama5d4-vdec.yaml > > @@ -0,0 +1,59 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > + > > +%YAML 1.2 > > +--- > > +$id: "http://devicetree.org/schemas/media/microchip,sama5d4-vdec.yaml#"; > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"; > > + > > +title: Hantro G1 VPU codec implemented on Microchip SAMA5D4 SoCs > > + > > +maintainers: > > + - Emil Velikov <emil.velikov@xxxxxxxxxxxxx> > > + > > +description: > > + Hantro G1 video decode accelerator present on Microchip SAMA5D4 SoCs. > > + > > +properties: > > + compatible: > > + const: microchip,sama5d4-vdec > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + interrupt-names: > > + items: > > + - const: vdec > > Why do you need a name? *-names are used to distinguish multiple entries > and don't add anything if only a single entry. > I guess you are right. I was about to argue that it makes backwards compatibility easier, but I suspect that's not the case either. > > + > > + clocks: > > + maxItems: 1 > > + > > + clock-names: > > + items: > > + - const: vdec_clk > > And here too? These are typically named for either the name of input > signal (hclk, aclk, etc.) or function ('core', 'bus', etc.). > Indeed, "core" might be a better choice. But it seems we don't need names here. Thanks, Ezequiel
