Re: [PATCH v2 00/10] Microship SAMA5D4 VPU support et al

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Emil,

On 24/03/2021 at 13:49, Emil Velikov wrote:
On Tue, 16 Mar 2021 at 17:23, Ezequiel Garcia <ezequiel@xxxxxxxxxxxxx> wrote:

On Thu, 2021-03-11 at 15:40 +0000, Emil Velikov wrote:
Emil Velikov (10):
   media: hantro: use G1_REG_INTERRUPT directly for the mpeg2
   media: hantro: imx: reuse MB_DIM define
   media: hantro: imx: remove duplicate dec_base init
   media: hantro: imx: remove unused include
   media: hantro: introduce hantro_g1.c for common API

For patches 1-5:

Reviewed-by: Ezequiel Garcia <ezequiel@xxxxxxxxxxxxx>

   media: dt-bindings: Document SAMA5D4 VDEC bindings

This one need to be reviewed by DT maintainers, I think.

Rob can you help with this one?

   media: hantro: add initial SAMA5D4 support

For patch 7:

Reviewed-by: Ezequiel Garcia <ezequiel@xxxxxxxxxxxxx>

   ARM: dts: sama5d4: enable Hantro G1 VDEC
   ARM: configs: at91: sama5: update with savedefconfig
   ARM: configs: at91: sama5: enable the Hantro G1 engine


These need review from Microchip maintainers.

Alexandre, Ludovic, Nicolas
Do you have any input of the patches or series as a whole?

The patch series looks good to me.

If needed on patches that we don't take ourselves, you can add my:
Acked-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>

Now, when we have the tag from Rob, how to coordinate these different pieces? Will it go through the media git tree? Will we benefit from a stable branch to share or will we just have to wait for the driver to hit Mainline before adding the defconfig and DT patches?

If you prefer we can drop the last two patches for the defconfig. I've
included those for posterity.
No strong opinion on my side, except that defconfig stuff might be better handled in at91 + arm-soc trees because we'll have other changes to queue for 5.13.

Thanks for the review Eze.
Would you recommend that I resend the series with your R-B or it's
better to wait for feedback from others?

Thanks a lot for this nice work. Best regards,
--
Nicolas Ferre



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux