[bug report] Revert "media: staging: atomisp: Remove driver"

[Dan Carpenter <dan.carpenter@xxxxxxxxxx>]

Hello Mauro Carvalho Chehab,

The patch ad85094b293e: "Revert "media: staging: atomisp: Remove
driver"" from Apr 19, 2020, leads to the following static checker
warning:

	drivers/staging/media/atomisp/pci/atomisp_fops.c:261 atomisp_q_video_buffers_to_css()
	error: buffer overflow 'asd->stream_env[stream_id]->pipes' 6 <= 6

drivers/staging/media/atomisp/pci/atomisp_fops.c
   234                  list_del_init(&vb->queue);
   235                  vb->state = VIDEOBUF_ACTIVE;
   236                  spin_unlock_irqrestore(&pipe->irq_lock, irqflags);
   237  
   238                  /*
   239                   * If there is a per_frame setting to apply on the buffer,
   240                   * do it before buffer en-queueing.
   241                   */
   242                  vm_mem = vb->priv;
   243  
   244                  param = pipe->frame_params[vb->i];
   245                  if (param) {
   246                          atomisp_makeup_css_parameters(asd,
   247                                                        &asd->params.css_param.update_flag,
   248                                                        &param->params);
   249                          atomisp_apply_css_parameters(asd, &param->params);
   250  
   251                          if (param->params.update_flag.dz_config &&
   252                              asd->run_mode->val != ATOMISP_RUN_MODE_VIDEO) {
   253                                  err = atomisp_calculate_real_zoom_region(asd,
   254                                          &param->params.dz_config, css_pipe_id);
   255                                  if (!err)
   256                                          asd->params.config.dz_config = &param->params.dz_config;
   257                          }
   258                          atomisp_css_set_isp_config_applied_frame(asd,
   259                                  vm_mem->vaddr);
   260                          atomisp_css_update_isp_params_on_pipe(asd,
   261                                                                asd->stream_env[stream_id].pipes[css_pipe_id]);
                                                                                                       ^^^^^^^^^^^
Can this be IA_CSS_PIPE_ID_NUM?  It looks that way.  The concern is
about the last caller in atomisp_qbuffers_to_css().

   262                          asd->params.dvs_6axis = (struct ia_css_dvs_6axis_config *)
   263                                                  param->params.dvs_6axis;
   264  
   265                          /*
   266                           * WORKAROUND:
   267                           * Because the camera halv3 can't ensure to set zoom
   268                           * region to per_frame setting and global setting at
   269                           * same time and only set zoom region to pre_frame

regards,
dan carpenter