Hey Sean, On Mon, 2021-01-25 at 18:02 +0000, Sean Young wrote: > Hi Bastien, > > On Mon, Jan 25, 2021 at 06:35:30PM +0100, Bastien Nocera wrote: > > Apparently used in the Dell Inspiron Zino HD 410 desktop: > > http://web.archive.org/web/20180805000711/http://www.dell.com/ba/p/desktops/inspiron-zino-hd-410/pd > > > > Manual linked in the remote definition itself. > > > > Signed-off-by: Bastien Nocera <hadess@xxxxxxxxxx> > > --- > > utils/keytable/rc_keymaps/dell_rc260.toml | 49 > > +++++++++++++++++++++++ > > These files are generated from the keymaps in the kernel tree. Those > can > be found in drivers/media/rc/keymaps/rc-*.c. > > A patch to create the keymap in the kernel tree would be better. This > is > also true for your other patch for the Xbox 360 rc keymap. > > The script which generates the toml file is in > utils/keytable/gen_keytables.pl > in the v4l-utils repo. > > Some keymaps are v4l-utils only; this is true for keymaps which can't > be > loaded from the kernel (ones that use BPF decoders). Looks like that's the second time I make the mistake in 2 years. I can't tell you how annoying that is. I sent patches to mark those files as auto-generated, and I would really appreciate if you could reconsider having those files' header marked as autogenerated. Maybe explain that files in /usr/... are generated, and that if the user wants to modify them that they should copy them to /etc/... > > 1 file changed, 49 insertions(+) > > create mode 100644 utils/keytable/rc_keymaps/dell_rc260.toml > > > > diff --git a/utils/keytable/rc_keymaps/dell_rc260.toml > > b/utils/keytable/rc_keymaps/dell_rc260.toml > > new file mode 100644 > > index 00000000..603d3a18 > > --- /dev/null > > +++ b/utils/keytable/rc_keymaps/dell_rc260.toml > > @@ -0,0 +1,49 @@ > > +[[protocols]] > > +name = "dell_rc260" > > +protocol = "rc6" > > +variant = "rc6_mce" > > The variant is rc-6-6a-32a for these scancodes. OK, noted. Cheers
