On Mon, Jan 25, 2021 at 01:50:48PM -0300, Helen Koike wrote:
> Hi Sakari,
>
> Thank you for the patch.
>
> On 1/25/21 10:22 AM, Sakari Ailus wrote:
> > From: Ezequiel Garcia <ezequiel@xxxxxxxxxxxxx>
> >
> > The v4l2_async_notifier_cleanup() documentation mentions
> > v4l2_fwnode_reference_parse_sensor_common, which was actually
> > introduced as v4l2_async_notifier_parse_fwnode_sensor_common(),
> > in commit 7a9ec808ad46 ("media: v4l: fwnode: Add convenience function for
> > parsing common external refs").
> >
> > The function drivers do use is
> > v4l2_async_register_subdev_sensor_common().
> >
> > Signed-off-by: Ezequiel Garcia <ezequiel@xxxxxxxxxxxxx>
> > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> > ---
> > include/media/v4l2-async.h | 17 +++++++++--------
> > 1 file changed, 9 insertions(+), 8 deletions(-)
> >
> > diff --git a/include/media/v4l2-async.h b/include/media/v4l2-async.h
> > index 0ddc06e36c08..f2cac0931372 100644
> > --- a/include/media/v4l2-async.h
> > +++ b/include/media/v4l2-async.h
> > @@ -174,9 +174,11 @@ v4l2_async_notifier_add_fwnode_subdev(struct v4l2_async_notifier *notifier,
> > *
> > * @notif: pointer to &struct v4l2_async_notifier
> > * @endpoint: local endpoint pointing to the remote sub-device to be matched
> > - * @asd: Async sub-device struct allocated by the caller. The &struct
> > - * v4l2_async_subdev shall be the first member of the driver's async
> > - * sub-device struct, i.e. both begin at the same memory address.
> > + * @asd_struct_size: size of the driver's async sub-device struct, including
> > + * sizeof(struct v4l2_async_subdev). The &struct
> > + * v4l2_async_subdev shall be the first member of
> > + * the driver's async sub-device struct, i.e. both
> > + * begin at the same memory address.
> > *
> > * Gets the remote endpoint of a given local endpoint, set it up for fwnode
> > * matching and adds the async sub-device to the notifier's @asd_list. The
> > @@ -184,13 +186,12 @@ v4l2_async_notifier_add_fwnode_subdev(struct v4l2_async_notifier *notifier,
> > * notifier cleanup time.
> > *
> > * This is just like @v4l2_async_notifier_add_fwnode_subdev, but with the
> > - * exception that the fwnode refers to a local endpoint, not the remote one, and
> > - * the function relies on the caller to allocate the async sub-device struct.
> > + * exception that the fwnode refers to a local endpoint, not the remote one.
> > */
> > -int
> > +struct v4l2_async_subdev *
> > v4l2_async_notifier_add_fwnode_remote_subdev(struct v4l2_async_notifier *notif,
> > struct fwnode_handle *endpoint,
> > - struct v4l2_async_subdev *asd);
> > + unsigned int asd_struct_size);
>
> This change should go with patch 1/14.
Yeah.
--
Sakari Ailus
