Hi "Uwe, I love your patch! Yet something to improve: [auto build test ERROR on 5a158981aafa7f29709034b17bd007b15cb29983] url: https://github.com/0day-ci/linux/commits/Uwe-Kleine-K-nig/isa-Make-the-remove-callback-for-isa-drivers-return-void/20210122-051235 base: 5a158981aafa7f29709034b17bd007b15cb29983 config: nios2-randconfig-r023-20210121 (attached as .config) compiler: nios2-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/0c93d705d2694019f3139d838eb6b48696c4f6dd git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Uwe-Kleine-K-nig/isa-Make-the-remove-callback-for-isa-drivers-return-void/20210122-051235 git checkout 0c93d705d2694019f3139d838eb6b48696c4f6dd # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): >> drivers/media/radio/radio-terratec.c:143:14: error: initialization of 'void (*)(struct device *, unsigned int)' from incompatible pointer type 'int (*)(struct device *, unsigned int)' [-Werror=incompatible-pointer-types] 143 | .remove = radio_isa_remove, | ^~~~~~~~~~~~~~~~ drivers/media/radio/radio-terratec.c:143:14: note: (near initialization for 'terratec_driver.driver.remove') cc1: some warnings being treated as errors vim +143 drivers/media/radio/radio-terratec.c 32c518364a03d336 Hans Verkuil 2012-01-16 138 32c518364a03d336 Hans Verkuil 2012-01-16 139 static struct radio_isa_driver terratec_driver = { 32c518364a03d336 Hans Verkuil 2012-01-16 140 .driver = { 32c518364a03d336 Hans Verkuil 2012-01-16 141 .match = radio_isa_match, 32c518364a03d336 Hans Verkuil 2012-01-16 142 .probe = radio_isa_probe, 32c518364a03d336 Hans Verkuil 2012-01-16 @143 .remove = radio_isa_remove, 32c518364a03d336 Hans Verkuil 2012-01-16 144 .driver = { 32c518364a03d336 Hans Verkuil 2012-01-16 145 .name = "radio-terratec", 32c518364a03d336 Hans Verkuil 2012-01-16 146 }, 32c518364a03d336 Hans Verkuil 2012-01-16 147 }, 32c518364a03d336 Hans Verkuil 2012-01-16 148 .io_params = &io, 32c518364a03d336 Hans Verkuil 2012-01-16 149 .radio_nr_params = &radio_nr, 32c518364a03d336 Hans Verkuil 2012-01-16 150 .io_ports = terratec_ioports, 32c518364a03d336 Hans Verkuil 2012-01-16 151 .num_of_io_ports = ARRAY_SIZE(terratec_ioports), 32c518364a03d336 Hans Verkuil 2012-01-16 152 .region_size = 2, 32c518364a03d336 Hans Verkuil 2012-01-16 153 .card = "TerraTec ActiveRadio", 32c518364a03d336 Hans Verkuil 2012-01-16 154 .ops = &terratec_ops, 32c518364a03d336 Hans Verkuil 2012-01-16 155 .has_stereo = true, 32c518364a03d336 Hans Verkuil 2012-01-16 156 .max_volume = 10, ^1da177e4c3f4152 Linus Torvalds 2005-04-16 157 }; ^1da177e4c3f4152 Linus Torvalds 2005-04-16 158 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
