Re: [PATCH v1 2/2] isa: Make the remove callback for isa drivers return void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi "Uwe,

I love your patch! Yet something to improve:

[auto build test ERROR on 5a158981aafa7f29709034b17bd007b15cb29983]

url:    https://github.com/0day-ci/linux/commits/Uwe-Kleine-K-nig/isa-Make-the-remove-callback-for-isa-drivers-return-void/20210122-051235
base:    5a158981aafa7f29709034b17bd007b15cb29983
config: arm-randconfig-r016-20210121 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/0c93d705d2694019f3139d838eb6b48696c4f6dd
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Uwe-Kleine-K-nig/isa-Make-the-remove-callback-for-isa-drivers-return-void/20210122-051235
        git checkout 0c93d705d2694019f3139d838eb6b48696c4f6dd
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> drivers/media/radio/radio-aztech.c:134:14: error: initialization of 'void (*)(struct device *, unsigned int)' from incompatible pointer type 'int (*)(struct device *, unsigned int)' [-Werror=incompatible-pointer-types]
     134 |   .remove  = radio_isa_remove,
         |              ^~~~~~~~~~~~~~~~
   drivers/media/radio/radio-aztech.c:134:14: note: (near initialization for 'aztech_driver.driver.remove')
   cc1: some warnings being treated as errors
--
>> drivers/media/radio/radio-rtrack2.c:116:14: error: initialization of 'void (*)(struct device *, unsigned int)' from incompatible pointer type 'int (*)(struct device *, unsigned int)' [-Werror=incompatible-pointer-types]
     116 |   .remove  = radio_isa_remove,
         |              ^~~~~~~~~~~~~~~~
   drivers/media/radio/radio-rtrack2.c:116:14: note: (near initialization for 'rtrack2_driver.driver.remove')
   cc1: some warnings being treated as errors
--
>> drivers/media/radio/radio-typhoon.c:145:14: error: initialization of 'void (*)(struct device *, unsigned int)' from incompatible pointer type 'int (*)(struct device *, unsigned int)' [-Werror=incompatible-pointer-types]
     145 |   .remove  = radio_isa_remove,
         |              ^~~~~~~~~~~~~~~~
   drivers/media/radio/radio-typhoon.c:145:14: note: (near initialization for 'typhoon_driver.driver.remove')
   cc1: some warnings being treated as errors
--
>> drivers/media/radio/radio-zoltrix.c:221:14: error: initialization of 'void (*)(struct device *, unsigned int)' from incompatible pointer type 'int (*)(struct device *, unsigned int)' [-Werror=incompatible-pointer-types]
     221 |   .remove  = radio_isa_remove,
         |              ^~~~~~~~~~~~~~~~
   drivers/media/radio/radio-zoltrix.c:221:14: note: (near initialization for 'zoltrix_driver.driver.remove')
   cc1: some warnings being treated as errors
--
>> drivers/media/radio/radio-gemtek.c:298:14: error: initialization of 'void (*)(struct device *, unsigned int)' from incompatible pointer type 'int (*)(struct device *, unsigned int)' [-Werror=incompatible-pointer-types]
     298 |   .remove  = radio_isa_remove,
         |              ^~~~~~~~~~~~~~~~
   drivers/media/radio/radio-gemtek.c:298:14: note: (near initialization for 'gemtek_driver.driver.remove')
   cc1: some warnings being treated as errors
--
>> drivers/media/radio/radio-trust.c:216:14: error: initialization of 'void (*)(struct device *, unsigned int)' from incompatible pointer type 'int (*)(struct device *, unsigned int)' [-Werror=incompatible-pointer-types]
     216 |   .remove  = radio_isa_remove,
         |              ^~~~~~~~~~~~~~~~
   drivers/media/radio/radio-trust.c:216:14: note: (near initialization for 'trust_driver.driver.remove')
   cc1: some warnings being treated as errors


vim +134 drivers/media/radio/radio-aztech.c

3088fba877ee8bf2 Hans Verkuil   2012-01-16  129  
3088fba877ee8bf2 Hans Verkuil   2012-01-16  130  static struct radio_isa_driver aztech_driver = {
3088fba877ee8bf2 Hans Verkuil   2012-01-16  131  	.driver = {
3088fba877ee8bf2 Hans Verkuil   2012-01-16  132  		.match		= radio_isa_match,
3088fba877ee8bf2 Hans Verkuil   2012-01-16  133  		.probe		= radio_isa_probe,
3088fba877ee8bf2 Hans Verkuil   2012-01-16 @134  		.remove		= radio_isa_remove,
3088fba877ee8bf2 Hans Verkuil   2012-01-16  135  		.driver		= {
3088fba877ee8bf2 Hans Verkuil   2012-01-16  136  			.name	= "radio-aztech",
3088fba877ee8bf2 Hans Verkuil   2012-01-16  137  		},
3088fba877ee8bf2 Hans Verkuil   2012-01-16  138  	},
3088fba877ee8bf2 Hans Verkuil   2012-01-16  139  	.io_params = io,
3088fba877ee8bf2 Hans Verkuil   2012-01-16  140  	.radio_nr_params = radio_nr,
3088fba877ee8bf2 Hans Verkuil   2012-01-16  141  	.io_ports = aztech_ioports,
3088fba877ee8bf2 Hans Verkuil   2012-01-16  142  	.num_of_io_ports = ARRAY_SIZE(aztech_ioports),
eb27fafef69568a8 Ondrej Zary    2013-07-19  143  	.region_size = 8,
3088fba877ee8bf2 Hans Verkuil   2012-01-16  144  	.card = "Aztech Radio",
3088fba877ee8bf2 Hans Verkuil   2012-01-16  145  	.ops = &aztech_ops,
3088fba877ee8bf2 Hans Verkuil   2012-01-16  146  	.has_stereo = true,
3088fba877ee8bf2 Hans Verkuil   2012-01-16  147  	.max_volume = 3,
^1da177e4c3f4152 Linus Torvalds 2005-04-16  148  };
^1da177e4c3f4152 Linus Torvalds 2005-04-16  149  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux