Re: [PATCH 1/1] v4l: fwnode: v4l2_async_notifier_parse_fwnode_endpoints is deprecated

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri 08 Jan 21, 00:07, Sakari Ailus wrote:
> Hi Ezequiel,
> 
> On Thu, Jan 07, 2021 at 04:31:58PM -0300, Ezequiel Garcia wrote:
> > Hi Sakari,
> > 
> > On Mon, 14 Dec 2020 at 18:45, Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> wrote:
> > >
> > > Document that v4l2_async_notifier_parse_fwnode_endpoints() is deprecated.
> > > Its functionality has been replaced by other, better functions. Also add a
> > > reference to an example if someone ends up wandering here.
> > >
> > 
> > I'm working on a series to clean up the v4l2_async API a bit,
> > and came across this patch.
> > 
> > As far as I can see, the only user of v4l2_async_notifier_parse_fwnode_endpoints
> > is drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c.
> 
> It may be that's the only one left. The intent was also to avoid anyone
> proposing new ones.
> 
> > Adding Maxime and Yong Deng, it would be great to get rid of this,
> > so we can remove the API, which would also allow us to remove
> > some other internal functions and therefore make the API a bit cleaner.
> 
> Yes, that'd be very nice. Then we could remove it altogether.

I've been touching that area a bit with my MIPI CSI-2 support series.
I'll try to get rid of it along the way if I need to respin the series,
or come up with a follow-up patch to remove the call to this function.

If I understand correctly, the preferred way now is to use:
- fwnode_graph_get_endpoint_by_id
- v4l2_fwnode_endpoint_parse
- v4l2_async_notifier_add_fwnode_remote_subdev

Is that correct? I think that's what I've been doing in the MIPI CSI-2
bridge drivers so far.

Cheers,

Paul

-- 
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux