Re: [PATCH 1/1] v4l: fwnode: v4l2_async_notifier_parse_fwnode_endpoints is deprecated

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sakari,

On Mon, 14 Dec 2020 at 18:45, Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> wrote:
>
> Document that v4l2_async_notifier_parse_fwnode_endpoints() is deprecated.
> Its functionality has been replaced by other, better functions. Also add a
> reference to an example if someone ends up wandering here.
>

I'm working on a series to clean up the v4l2_async API a bit,
and came across this patch.

As far as I can see, the only user of v4l2_async_notifier_parse_fwnode_endpoints
is drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c.

Adding Maxime and Yong Deng, it would be great to get rid of this,
so we can remove the API, which would also allow us to remove
some other internal functions and therefore make the API a bit cleaner.

Thanks,
Ezequiel

> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> ---
>  include/media/v4l2-fwnode.h | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/include/media/v4l2-fwnode.h b/include/media/v4l2-fwnode.h
> index 4365430eea6f..d0a1293379ab 100644
> --- a/include/media/v4l2-fwnode.h
> +++ b/include/media/v4l2-fwnode.h
> @@ -453,6 +453,10 @@ typedef int (*parse_endpoint_func)(struct device *dev,
>   * @parse_endpoint: Driver's callback function called on each V4L2 fwnode
>   *                 endpoint. Optional.
>   *
> + * DEPRECATED! This function is deprecated. Don't use it in new drivers.
> + * Instead see an example in cio2_parse_firmware() function in
> + * drivers/media/pci/intel/ipu3/ipu3-cio2.c .
> + *
>   * Parse the fwnode endpoints of the @dev device and populate the async sub-
>   * devices list in the notifier. The @parse_endpoint callback function is
>   * called for each endpoint with the corresponding async sub-device pointer to
> --
> 2.29.2
>



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux