Re: [PATCH] v4l: videobuf: qbuf now uses relevant v4l2_buffer fields for OUTPUT types

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Pawel,

On Thursday 22 April 2010 11:24:52 Pawel Osciak wrote:
> >Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
> >> According to the V4L2 specification, applications set bytesused, field
> >> and timestamp fields of struct v4l2_buffer when the buffer is intended
> >> for output and memory type is MMAP. This adds proper copying of those
> >> values to videobuf_buffer so drivers can use them.
> >
> >Why only for the MMAP memory type ? Don't drivers need the information for
> >USERPTR buffers as well ?
> 
> It is only mentioned for the MMAP memory type:
> http://linuxtv.org/downloads/video4linux/API/V4L2_API/spec-single/v4l2.html
> #vidioc-qbuf although it would make sense to do this for USERPTR as well.
> Maybe I am trying too hard to stay 100% faithful to the documentation, I
> guess it should be corrected as well then?

This wouldn't be the first time the spec is wrong :-) I'd like other people's 
opinion on this, but I think we should fix the spec and copy the values for 
both MMAP and USERPTR.

-- 
Regards,

Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux