Re: [PATCH] v4l: videobuf: qbuf now uses relevant v4l2_buffer fields for OUTPUT types

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Pawel,

On Wednesday 21 April 2010 11:44:27 Pawel Osciak wrote:
> According to the V4L2 specification, applications set bytesused, field and
> timestamp fields of struct v4l2_buffer when the buffer is intended for
> output and memory type is MMAP. This adds proper copying of those values
> to videobuf_buffer so drivers can use them.

Why only for the MMAP memory type ? Don't drivers need the information for 
USERPTR buffers as well ?

> Signed-off-by: Pawel Osciak <p.osciak@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> ---
>  drivers/media/video/videobuf-core.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/media/video/videobuf-core.c
> b/drivers/media/video/videobuf-core.c index 63d7043..e573ca7 100644
> --- a/drivers/media/video/videobuf-core.c
> +++ b/drivers/media/video/videobuf-core.c
> @@ -549,6 +549,13 @@ int videobuf_qbuf(struct videobuf_queue *q, struct
> v4l2_buffer *b) "but buffer addr is zero!\n");
>  			goto done;
>  		}
> +		if (q->type == V4L2_BUF_TYPE_VIDEO_OUTPUT
> +		    || q->type == V4L2_BUF_TYPE_VBI_OUTPUT
> +		    || q->type == V4L2_BUF_TYPE_SLICED_VBI_OUTPUT) {
> +			buf->size = b->bytesused;
> +			buf->field = b->field;
> +			buf->ts = b->timestamp;
> +		}
>  		break;
>  	case V4L2_MEMORY_USERPTR:
>  		if (b->length < buf->bsize) {

-- 
Regards,

Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux