Hi Mauro,
On Thu, Dec 3, 2020 at 8:53 AM Mauro Carvalho Chehab
<mchehab+huawei@xxxxxxxxxx> wrote:
> Em Thu, 3 Dec 2020 08:08:09 +0100
> Hans Verkuil <hverkuil@xxxxxxxxx> escreveu:
> > On 03/12/2020 08:06, Hans Verkuil wrote:
> > > On 03/12/2020 07:58, Mauro Carvalho Chehab wrote:
> > >> Em Thu, 26 Nov 2020 08:47:55 +0100
> > >> Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> escreveu:
> > >>
> > >>> As reported in patch 2/2 commit message the the VNCSI_IFMD register
> > >>> has the following limitations according to chip manual revision 2.20
> > >>>
> > >>> - V3M, V3H and E3 do not support the DES1 field has they do not feature
> > >>> a CSI20 receiver.
> > >>> - D3 only supports parallel input, and the whole register shall always
> > >>> be written as 0.
> > >>>
> > >>> This patch upports the BSP change commit f54697394457
> > >>> ("media: rcar-vin: Fix VnCSI_IFMD register access for r8a77990") from
> > >>> Koji Matsuoka
> > >>
> > >> As checkpatch warned:
> > >>
> > >> -:22: WARNING: Unknown commit id 'f54697394457', maybe rebased or not pulled?
> > >>
> > >> There's no such commit upstream. Are you referring to an OOT patch?
> > >>
> > >> If so, you should provide an URL from where the patch is stored,
> > >> as otherwise this comment won't make any sense upstream.
> > >>
> > >> If you can't provide such URL, please adjust the comment to provide
> > >> a description that won't be dependent of such OOT commit.
> >
> > Ah, it's too early in the morning for me. I didn't read your email carefully
> > enough.
>
> Yeah, I realized that the commit is for an OOT patch ;-)
>
> The main point is that Patch descriptions should be self-contained, bringing
> everything that is needed to describe the patch on it. It is acceptable to have
> URLs pointing to some external references that will be there as long as the
> driver will remain at the Linux Kernel. The way the description currently is,
> it doesn't fulfill such criteria.
>
> -
>
> Btw, I was unable to find such commit, even googling for it.
https://github.com/renesas-rcar/linux-bsp/commit/f54697394457
It's indeed unfortunate that Google doesn't support searching by
git commit ID.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
