Hi Hans, On Wed, Dec 2, 2020 at 5:50 AM Hans Verkuil <hverkuil-cisco@xxxxxxxxx> wrote: > > struct coda_platform_data *pdata = pdev->dev.platform_data; > > So this can be dropped as well (and all related code), right? Yes, you are right. > And you can also remove include/linux/platform_data/media/coda.h. Yes, thanks for the review. I have sent v2 with your suggestions. Cheers